Skip to content

feat(nestjs): Remove SentryTracingInterceptor, SentryGlobalGraphQLFilter, SentryGlobalGenericFilter #14761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 17, 2024
Merged

feat(nestjs): Remove SentryTracingInterceptor, SentryGlobalGraphQLFilter, SentryGlobalGenericFilter #14761

merged 8 commits into from
Dec 17, 2024

Conversation

@andreiborza
Copy link
Member

Note: we keep SentryTracingInterceptor to maintain parameterized transaction names but remove the public export.

Closes: #14295

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.22 KB - -
@sentry/browser - with treeshaking flags 21.88 KB - -
@sentry/browser (incl. Tracing) 35.74 KB - -
@sentry/browser (incl. Tracing, Replay) 72.99 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.37 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.39 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.77 KB - -
@sentry/browser (incl. Feedback) 39.96 KB - -
@sentry/browser (incl. sendFeedback) 27.83 KB - -
@sentry/browser (incl. FeedbackAsync) 32.59 KB - -
@sentry/react 25.92 KB - -
@sentry/react (incl. Tracing) 38.59 KB - -
@sentry/vue 27.46 KB - -
@sentry/vue (incl. Tracing) 37.6 KB - -
@sentry/svelte 23.39 KB - -
CDN Bundle 24.36 KB - -
CDN Bundle (incl. Tracing) 37.42 KB - -
CDN Bundle (incl. Tracing, Replay) 72.52 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.89 KB - -
CDN Bundle - uncompressed 71.55 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.92 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 224.97 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.19 KB - -
@sentry/nextjs (client) 38.85 KB - -
@sentry/sveltekit (client) 36.27 KB - -
@sentry/node 158.06 KB - -
@sentry/node - without tracing 98.99 KB - -
@sentry/aws-serverless 126.72 KB - -

View base workflow run

@lforst
Copy link
Contributor

lforst commented Dec 17, 2024

didnt check because i am out but i think i duplicated the code for the interceptor into init() so that we can remove it

@andreiborza
Copy link
Member Author

andreiborza commented Dec 17, 2024 •
edited
Loading

didnt check because i am out but i think i duplicated the code for the interceptor into init() so that we can remove it

that was for SentryService, I don't think we can replicate that for the interceptor.

@andreiborza andreiborza force-pushed the ab/remove-nest-tracing-interceptor-graphqlfilter-genericfilter branch from 67a373b to 55a8659 Compare December 17, 2024 16:23
Base automatically changed from ab/remove-nest-sentryservice to develop December 17, 2024 16:41
@andreiborza andreiborza force-pushed the ab/remove-nest-tracing-interceptor-graphqlfilter-genericfilter branch from 55a8659 to 0ae6097 Compare December 17, 2024 16:42
@andreiborza andreiborza merged commit a921440 into develop Dec 17, 2024
127 checks passed
@andreiborza andreiborza deleted the ab/remove-nest-tracing-interceptor-graphqlfilter-genericfilter branch December 17, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chargome chargome chargome approved these changes

@lforst lforst Awaiting requested review from lforst

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v9] Remove NestJS SentryTracingInterceptor, SentryGlobalGraphQLFilter, SentryGlobalGenericFilter

3 participants

@andreiborza @lforst @chargome